This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Only scroll one axis at a time, whichever has the greater delta #15324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15239
This PR fixes a logic error in the following line of code:
I didn't account for the "short-circuit" behavior of the or statement. With this code, we first attempt to scroll horizontally by
deltaX
, and if we scroll even a little, then we never attempt to scroll vertically. When I tested this originally, I thought we were getting the "one axis at a time" behavior automatically somehow, but really I was just seeing this bug. 🙈This PR restores the behavior prior to 1.19 of scrolling only on one axis at a time, whichever has the greater delta.