This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Always honor scroll intent on mousewheel #15487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a change in the way we respond to mousewheel events. In particular, if `delta * scrollSensitivity` is less than 1 or greater than -1, we will round it up or down in an attempt to honor the user's scroll intent.
nathansobo
approved these changes
Aug 29, 2017
| @@ -1209,7 +1209,6 @@ describe('TextEditorComponent', () => { | |||
| } | |||
|
|
|||
| { | |||
| global.debug = true | |||
as-cii
pushed a commit
that referenced
this pull request
Aug 31, 2017
Always honor scroll intent on mousewheel
as-cii
pushed a commit
that referenced
this pull request
Aug 31, 2017
Always honor scroll intent on mousewheel
as-cii
pushed a commit
that referenced
this pull request
Sep 2, 2017
Always honor scroll intent on mousewheel
as-cii
pushed a commit
that referenced
this pull request
Sep 5, 2017
Always honor scroll intent on mousewheel
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15467
This pull-request introduces a change in the way we respond to mousewheel events. In particular, if
-1 < delta * scrollSensitivity < 1, we will scroll up or down by 1 in an attempt to honor the user's scroll intent./cc: @iolsen @lee-dohm @ungb @nathansobo