This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix #16538: Middle-click pastes into read only editor on Linux #16611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where users on Linux are able to paste into read only TextEditors by clicking the middle mouse button. The fix is to check for whether the TextEditorComponent's isInputEnabled method returns true before pasting with middle click on Linux.
jasonrudolph
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
@daviwil: The diff looks good. 👍
Can I talk you into summarizing the verification steps?
|
Sure! Added it to the PR description. |
nathansobo
approved these changes
Jan 23, 2018
|
Definitely works :) Thanks all! |
Nice. Thanks, @daviwil! Those verification steps look great. ⚡ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where users on Linux are able to paste into
read only TextEditors by clicking the middle mouse button. The fix is
to check for whether the TextEditorComponent's isInputEnabled method
returns true before pasting with middle click on Linux.
Verification Process
On Linux:
atom.workspace.getActiveTextEditor().setReadOnly(true)atom.workspace.getActiveTextEditor().setReadOnly(false)