Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Synchronously track URIs in the process of opening #17021

Merged
merged 4 commits into from
Mar 26, 2018

Conversation

smashwilson
Copy link
Contributor

Synchronously track a set of incoming URIs within a Workspace. If another item is being opened at the same URI, await its Promise before continuing, to ensure that ::open() has a chance to find the Item added by the first call if it succeeds.

Fixes #13914.

@smashwilson
Copy link
Contributor Author

Hmm, that CircleCI failure might be legit:

ResultsView
  opening results
    it opens the file containing the result in a non-pending state when the search result is double-clicked
      Expected <TextEditor 1552> to be null.
        Error: Expected <TextEditor 1552> to be null.
        at /Users/distiller/atom/node_modules/find-and-replace/spec/results-view-spec.js:417:75
        at Generator.next (<anonymous>)
        at step (/Users/distiller/atom/node_modules/find-and-replace/spec/results-view-spec.js:1:428)
        at <anonymous>

@smashwilson
Copy link
Contributor Author

atom/find-and-replace#1006 should get this green again. I'll crunch on a few issues over there to... conserve release numbers I guess?

@smashwilson smashwilson merged commit d4185b2 into master Mar 26, 2018
@smashwilson smashwilson deleted the aw/d-d-d-double-open branch March 26, 2018 18:08
@matthewwithanm
Copy link
Contributor

thanks @smashwilson!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants