New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronously track URIs in the process of opening #17021

Merged
merged 4 commits into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Member

smashwilson commented Mar 23, 2018

Synchronously track a set of incoming URIs within a Workspace. If another item is being opened at the same URI, await its Promise before continuing, to ensure that ::open() has a chance to find the Item added by the first call if it succeeds.

Fixes #13914.

smashwilson added some commits Mar 23, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented Mar 24, 2018

Hmm, that CircleCI failure might be legit:

ResultsView
  opening results
    it opens the file containing the result in a non-pending state when the search result is double-clicked
      Expected <TextEditor 1552> to be null.
        Error: Expected <TextEditor 1552> to be null.
        at /Users/distiller/atom/node_modules/find-and-replace/spec/results-view-spec.js:417:75
        at Generator.next (<anonymous>)
        at step (/Users/distiller/atom/node_modules/find-and-replace/spec/results-view-spec.js:1:428)
        at <anonymous>
@smashwilson

This comment has been minimized.

Member

smashwilson commented Mar 26, 2018

atom/find-and-replace#1006 should get this green again. I'll crunch on a few issues over there to... conserve release numbers I guess?

@smashwilson smashwilson merged commit d4185b2 into master Mar 26, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/d-d-d-double-open branch Mar 26, 2018

@matthewwithanm

This comment has been minimized.

Member

matthewwithanm commented Mar 26, 2018

thanks @smashwilson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment