New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid writing to config file while quitting #17166

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@maxbrunsfeld
Contributor

maxbrunsfeld commented Apr 18, 2018

Refs #17060

/cc @Arcanemagus - I was never able to reproduce the config loss using your steps. It seems like it might be more unlikely on macOs, or depending on the speed of your disk. I'm going to go ahead speculatively merge this PR that I think might fix the problem. When you get a chance, would you mind trying to reproduce the bug with a new build?

@maxbrunsfeld maxbrunsfeld merged commit d50349f into master Apr 18, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-dont-save-config-while-quitting branch Apr 18, 2018

@Arcanemagus

This comment has been minimized.

Contributor

Arcanemagus commented Apr 19, 2018

Apparently reproducing #17060 is a lot more difficult on compiled builds than I remember. It takes ~4 restarts to reproduce on Atom v1.27.0-beta0, but ~40 on a build based on the same commit 😮.

In any case I did manage to reproduce it on a build based on the commit right before this merged, and I so far haven't been able to reproduce on a build after this was merged so I think we can call this one mitigated. 🎉

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Apr 19, 2018

In any case I did manage to reproduce it on a build based on the commit right before this merged

Nice work!

@Arcanemagus

This comment has been minimized.

Contributor

Arcanemagus commented Apr 19, 2018

It seems I spoke too soon, opened up that profile/build again to check something else and the settings were wiped. I'm wondering if a very rare bug I was seeing during testing might actually be related. Trying to find better reproduction steps.

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17166 from atom/mb-dont-save-config-while-quitting
Avoid writing to config file while quitting

maxbrunsfeld added a commit that referenced this pull request Apr 25, 2018

Merge pull request #17166 from atom/mb-dont-save-config-while-quitting
Avoid writing to config file while quitting
@SystemLogoff

This comment has been minimized.

SystemLogoff commented May 17, 2018

This has happened to me as well, using only the love2d ide packages.

It's a huge pain, but I've become great at setting up atom again, and again, and again.

@rsese rsese referenced this pull request Jun 12, 2018

Closed

Atom config reset #16786

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment