Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid writing to config file while quitting #17166
/cc @Arcanemagus - I was never able to reproduce the config loss using your steps. It seems like it might be more unlikely on macOs, or depending on the speed of your disk. I'm going to go ahead speculatively merge this PR that I think might fix the problem. When you get a chance, would you mind trying to reproduce the bug with a new build?
Apr 18, 2018
Apparently reproducing #17060 is a lot more difficult on compiled builds than I remember. It takes ~4 restarts to reproduce on Atom v1.27.0-beta0, but ~40 on a build based on the same commit
In any case I did manage to reproduce it on a build based on the commit right before this merged, and I so far haven't been able to reproduce on a build after this was merged so I think we can call this one mitigated.