Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Avoid writing to config file while quitting #17166

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

maxbrunsfeld
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld commented Apr 18, 2018

Refs #17060

/cc @Arcanemagus - I was never able to reproduce the config loss using your steps. It seems like it might be more unlikely on macOs, or depending on the speed of your disk. I'm going to go ahead speculatively merge this PR that I think might fix the problem. When you get a chance, would you mind trying to reproduce the bug with a new build?

@maxbrunsfeld maxbrunsfeld merged commit d50349f into master Apr 18, 2018
@maxbrunsfeld maxbrunsfeld deleted the mb-dont-save-config-while-quitting branch April 18, 2018 22:34
@Arcanemagus
Copy link
Contributor

Apparently reproducing #17060 is a lot more difficult on compiled builds than I remember. It takes ~4 restarts to reproduce on Atom v1.27.0-beta0, but ~40 on a build based on the same commit 😮.

In any case I did manage to reproduce it on a build based on the commit right before this merged, and I so far haven't been able to reproduce on a build after this was merged so I think we can call this one mitigated. 🎉

@maxbrunsfeld
Copy link
Contributor Author

In any case I did manage to reproduce it on a build based on the commit right before this merged

Nice work!

@Arcanemagus
Copy link
Contributor

It seems I spoke too soon, opened up that profile/build again to check something else and the settings were wiped. I'm wondering if a very rare bug I was seeing during testing might actually be related. Trying to find better reproduction steps.

maxbrunsfeld pushed a commit that referenced this pull request Apr 25, 2018
Avoid writing to config file while quitting
maxbrunsfeld pushed a commit that referenced this pull request Apr 25, 2018
Avoid writing to config file while quitting
@sysl-dev
Copy link

This has happened to me as well, using only the love2d ide packages.

It's a huge pain, but I've become great at setting up atom again, and again, and again.

@rsese rsese mentioned this pull request Jun 12, 2018
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants