New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize tree-sitter HighlightIterator when there are many injections #18435

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Nov 14, 2018

In the course of addressing atom/language-javascript#600, I noticed that when there are a large number of language injections in a large file, highlighting operations and scope descriptor queries become very slow. Specifically, this line of code.

In atom/text-buffer#305, I made it possible to avoid examining every single injection when seeking a highlight iterator. This PR takes advantage of that capability.

@maxbrunsfeld maxbrunsfeld merged commit 3f67183 into master Nov 14, 2018

3 checks passed

Atom Pull Requests #20181114.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-optimize-many-injections branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment