This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add JSDoc injection w/ tree-sitter-jsdoc #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
Rationale
When we introduced Tree-sitter, we removed the feature of syntax-highlighting JSDoc comments in JavaScript. This PR adds back JSDoc highlighting using a new Tree-sitter parser: tree-sitter-jsdoc.
Possible Drawbacks
This adds many more injections in some JavaScript files, so it may affect performance. In the course of adding this, I already found and fixed two performance bottlenecks related to large numbers of language injections:
/cc @Ben3eeE