Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upgrade to Electron 3.0 #18603

Merged
merged 22 commits into from
Feb 1, 2019
Merged

Upgrade to Electron 3.0 #18603

merged 22 commits into from
Feb 1, 2019

Commits on Jan 18, 2019

  1. ⬆️ :electron: electron@3.0.0-beta.9

    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    8dbd98a View commit details
    Browse the repository at this point in the history
  2. ⬆️ @atom/nsfw

    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    84e352f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    71bf72a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e5ba7c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1276f6f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7399753 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    89de78b View commit details
    Browse the repository at this point in the history
  8. :arrow_up fs-plus@3.1.1

    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b692f0d View commit details
    Browse the repository at this point in the history
  9. ⬆️ :electron: electron@3.0.13

    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    10dbd69 View commit details
    Browse the repository at this point in the history
  10. Make invalid JS file fail Babel spec again

    This change uses a different JavaScript syntax to cause the "when a .js file
    does not start with 'use babel'" spec to fail again after upgrading to Electron
    3 / Node 10.3.0.  The previous generator syntax seems to be supported in the
    version of V8 used by Node 10 so we now need to use the 'export default' syntax
    to trigger an error.
    
    I've verified that changing the first line of this file to 'use babel' causes
    the file to load successfully, so it seems this new syntax is effective to
    verify the desired behavior.
    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    8eccaf2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    eee7ae8 View commit details
    Browse the repository at this point in the history
  12. Use correct fontWeight value in ThemeManager spec

    In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed
    numeric value of the style instead of the original descriptive name.  We now
    look for value '700' which corresponds to the value of 'bold'.
    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ff42923 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f70be77 View commit details
    Browse the repository at this point in the history
  14. Remove listeners for specific events in Task class

    This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
    the `removeAllListeners` method to no longer remove all listeners for any event
    name when no argument is passed:
    
    nodejs/node#20924
    
    This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
    workaround when we move to Electron 4.0 to avoid future event handler leaks.
    daviwil committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    7b7fd7b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a41b69e View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Update StyleManager specs to address deprecated ::shadow selectors

    As of Chromium 63, ::shadow CSS selectors have been fully removed:
    
    https://developers.google.com/web/updates/2017/10/remove-shadow-piercing
    
    As a result, any usage of ::shadow in a stylesheet seems to get removed as soon
    as the stylesheet is applied to an HTMLStyleElement.  Since we have a couple of tests
    that expect ::shadow selectors to be present, we must remove those expectations
    since those selectors do not appear any longer.
    daviwil committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    11ed913 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Configuration menu
    Copy the full SHA
    7248737 View commit details
    Browse the repository at this point in the history
  2. ⬆️ spell-check@3.5.1

    daviwil committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    b06da5d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. ⬆️ :electron: electron@3.0.14

    daviwil committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    fdece6f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Remove cached-run-in-this-context dependency

    This dependency is no longer needed now that we use Node's built-in APIs
    daviwil committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    6903be1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. ⬆️ text-buffer@13.15.3

    daviwil committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    fec6856 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3714a8d View commit details
    Browse the repository at this point in the history