Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update Mac icon to be flatter, to work with Yosemite styling #3089

Closed
wants to merge 3 commits into from

Conversation

ParkerK
Copy link

@ParkerK ParkerK commented Jul 25, 2014

Yosemite has a much flatter look to it, and all of the default Mac apps have had their icons changed. I updated the Atom icon to fit in with these theme a little better. Any feedback would be appreciated :)

Old: atom
New: f2b4523d650ae78d-64x64

@kevinsawicki
Copy link
Contributor

When I look at the new icon there appears to be a smaller atom orbital in the center, is this intended?

screen shot 2014-07-25 at 9 46 13 am

@benogle
Copy link
Contributor

benogle commented Jul 25, 2014

It's atoms all the way down, man.

@benogle
Copy link
Contributor

benogle commented Jul 25, 2014

I suggest we have @cameronmcefee or @jeejkang do this work.

@ParkerK
Copy link
Author

ParkerK commented Jul 25, 2014

Oh whoops, that was an artifact, I should have caught that. I will update with the correct stuff later. Thanks for finding that @kevinsawicki

@DomT4
Copy link

DomT4 commented Jul 25, 2014

This looks nice. The glassy texture of the current icon definitely looks out of place on Yosemite. This article covers the move away from glass & onto a more flat plane nicely.

@ParkerK
Copy link
Author

ParkerK commented Jul 25, 2014

Fixed the artifacts Kevin pointed out, I also updated the file icon.

New: atom128
Old: atomold128
New: file128
Old: fileold128

@cameronmcefee
Copy link

Hi @ParkerK, thanks for your contribution! Because your pull request modifies a trademarked design, I need to check with our legal department to make sure the law would allow such a modification to be made (trademark law is tricky about these thigns). Once I know if it's ok, I'll provide some feedback about how we can move forward with things.

@batjko
Copy link
Contributor

batjko commented Jul 26, 2014

I wouldn't mind this for Windows either. Win8 design is more flat than Win7, so it would certainly fit in while not particularly hurting other versions.

@mehcode
Copy link
Contributor

mehcode commented Jul 26, 2014

Just throwing a general 👍 and that I would love to see this new icon on linux as well.

@ParkerK
Copy link
Author

ParkerK commented Jul 28, 2014

Thanks @cameronmcefee ! Understood, I'm more than happy to help to make it work with whatever guidelines they give.

@batjko good idea, something like this maybe?
atomwin8

@mehcode thanks!

@batjko
Copy link
Contributor

batjko commented Jul 28, 2014

@ParkerK I don't use the metro interface, but I'm guess that would work.
From a desktop perspective, I'd be quite happy with the one you suggested for mac above.

@philipgiuliani
Copy link
Contributor

I think the Atom icon shouldn't be changed to often. Of course it would be a nice change for yosemite, but whats with the Windows 7 users ect.?

If you want to change it, i would recommend one of this two, that are really nice.

https://dribbble.com/shots/1615345-Atom-Editor-Yosemite-App-Icon-wo-shadow
https://dribbble.com/shots/1614754-Atom-Yosemite-Icon

Another thread about Atom Yosemite icon: https://discuss.atom.io/t/alternative-atom-yosemite-icon/10093

@batjko
Copy link
Contributor

batjko commented Jul 28, 2014

@philipgiuliani I don't see why any of those two or three suggested icons wouldn't work for Windows.
Unlike OSX, Windows icons are not unified. There's a lot more variety and they'd all fit IMO.

@ParkerK
Copy link
Author

ParkerK commented Jul 28, 2014

Ahh, yeah @batjko I went right to metro for some reason. Yes, the icon should work with both Linux and Windows, it's much flatter now, but flat isn't OS X only, and neither Linux nor Windows are unified like OS X is

@philipgiuliani
Copy link
Contributor

@batjko yeah you're right, now i looked over my Windows Software i use, and they all are really different... Just OS X is a little bit "strict" here :)

@cameronmcefee
Copy link

Hi Everyone,

We've talked it out and have decided that we won't be accepting brand-related pull requests because of the murky nature of authorship. Changing your own personal icon is totally legit as far as the license goes so have at it if you so choose, but we're going to keep the official brand updates to GitHub staff only.

Sorry for the less than ideal result, but we super appreciate that you care enough about Atom to contribute.

@batjko
Copy link
Contributor

batjko commented Jul 29, 2014

Fair enough.

@kevinsawicki
Copy link
Contributor

@cameronmcefee could you update the CONTRIBUTING.md file with this information?

@ParkerK
Copy link
Author

ParkerK commented Aug 1, 2014

What if I just agree to transfer all ownership to you guys?

Thanks for looking into this, either way

@Stanzilla
Copy link

http://appicontemplate.com/osx has a pretty relaxed license though

@DomT4
Copy link

DomT4 commented Oct 29, 2014

As far as I know they're more concerned about artistic copyright than the tools used, in this case because @ParkerK has artistic copyright over his creation even if it does use Github's Atom icon design.

It wouldn't be a massively difficult thing to get around, Github and X can draw up a contract where the work done belongs to Github entirely and irrevocably and in return the artist is paid $0.01 or something trivial along those lines, but I can understand why Github wants to avoid dealing with the slaughterhouse of legislation and regulation on this particular issue.

@Stanzilla
Copy link

I actually meant that someone from the team could just use the template and come up with an icon without having the whole contract deal. Should be easy enough.

@cameronmcefee cameronmcefee mentioned this pull request Dec 30, 2014
4 tasks
@ahmadseleem
Copy link

@kevinsawicki @benogle @nathansobo
I made these 4 icons:
https://github.com/ahmadseleem/Atom-Classy-icons

What do you guys think ?

I use this personally:

Classy Atom

alt tag

@ahmadseleem
Copy link

This icon looks even much better when used and rendered as an icon.
Try it and you'll see what I mean.

@batjko
Copy link
Contributor

batjko commented Jul 18, 2015

@ahmadseleem
Copy link

If you still prefer green background:

Greener is also cool:

alt tag

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants