This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Upgrade to Jasmine 3 #1103
Merged
Upgrade to Jasmine 3 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also take care of #1095 as well as other security vulnerabilities that were present in the package dependencies |
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
aminya
approved these changes
Jan 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This will replace the default Atom test runner powered by the long outdated Jasmine 1.3 with a new custom test runner powered by the latest Jasmine 3.6.
Benefits
The documentation of Jasmine 1.3 is very poor, so upgrading the version will allow developers to write tests more efficiently with the new Jasmine docs. It also improves the developer experience because Jasmine 3 is more pleasant to work with.
Possible Drawbacks
Not that I can think of any.