New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on implementation details of autocomplete-plus in tests #85

Merged
merged 1 commit into from Aug 19, 2017

Conversation

Projects
None yet
1 participant
@nathansobo
Contributor

nathansobo commented Aug 16, 2017

These implementation details have changed in atom/autocomplete-plus#876

Instead, rely on implementation details of the snippets provider. These tests are really too integrated and touching too much. It would be better to have something more isolated that installs autocomplete-plus as a dev dependency and tests against its API directly.

@ungb Assuming this builds green against the current Atom, you should be able to publish a patch and add it to your branch where you're upgrading autocomplete-plus, and the tests should pass. 馃

Don't rely on implementation details of autocomplete-plus in tests
These implementation details have changed in autocomplete-plus#876

Instead, rely on implementation details of the snippets provider. These
tests are really too integrated and touching too much. It would be
better to have something more isolated that installs autocomplete-plus
as a dev dependency and tests against its API directly.

@nathansobo nathansobo merged commit 25b337a into master Aug 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the ns-fix-tests branch Aug 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment