This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't rely on implementation details of autocomplete-plus in tests #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These implementation details have changed in autocomplete-plus#876 Instead, rely on implementation details of the snippets provider. These tests are really too integrated and touching too much. It would be better to have something more isolated that installs autocomplete-plus as a dev dependency and tests against its API directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These implementation details have changed in atom/autocomplete-plus#876
Instead, rely on implementation details of the snippets provider. These tests are really too integrated and touching too much. It would be better to have something more isolated that installs autocomplete-plus as a dev dependency and tests against its API directly.
@ungb Assuming this builds green against the current Atom, you should be able to publish a patch and add it to your branch where you're upgrading autocomplete-plus, and the tests should pass. 🤞