This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't disable snippets provider in strings and comments #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling snippets within strings and comments probably reduces noise in a lot of scenarios, but can create confusion when snippets don't work in certain circumstances. The correct place to handle this would be in snippets themselves, where we would explicitly disable snippets in contexts where they don't make sense. Our current system makes this pretty difficult to achieve though, since most snippets are tied to the entire scope of the target language. This is something to consider when improving snippets in the future. Signed-off-by: Antonio Scandurra <as-cii@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
🍐 d with @as-cii
Disabling snippets within strings and comments probably reduces noise in a lot of scenarios, but can create confusion when snippets don't work in certain circumstances. The correct place to handle this would be in snippets themselves, where we would explicitly disable snippets in contexts where they don't make sense. Our current system makes this pretty difficult to achieve though, since most snippets are tied to the entire scope of the target language. This is something to consider when improving snippets in the future.