This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Skip over tag attributes when selecting inside tags #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
When selecting inside tags, grab the full range of the tag rather than just the tag name range. This change allows the attributes to be skipped, leading to the actual area between tags being highlighted.
Alternate Designs
None.
Benefits
Using the
bracket-matcher:select-inside-brackets
command will work correctly for tags with attributes.Possible Drawbacks
There may be a slight performance decrease compared to before when the cursor is currently on a tag. This is because we have to re-search for the tags in order to get the full range (i.e. there is no way that I know of to grab the full range from the existing range).
Applicable Issues
Fixes #117