Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add config option to use `ripgrep` for scanning files #1086
This PR adds a config option to enable
(the last measure has been done to check the less favourable case for
The search behaviour with
To mitigate that, I've done quite extensive tests but I'll keep checking for potential edge cases. Also, I'm planning to leave this config flag at least for 1 version of Atom so we can catch as many issues as possible before shipping this to users by default .
May 28, 2019
Sure, provided it's not time-sensitive because I reckon it'll take a while --- I'll have to set up a dev enviro and figure out how to run it (plus I have little time ATM, but who does). Alternatively, I can write the code + tests blindly, cross my fingers and let the CI and reviewers do the rest :).
Btw, should a new event metadata field be added, too?
Thanks @dwelle! I don't think time sensitive, so it's fine
Just take into account that the search logic is in Atom core. You can add a new option to the [
You don't need to care about the
Also, make sure to create a new test on the
Regarding the metadata field, I don't think it's needed for now. Only if we see that the performance of the searches regress after this change we'll add that.
Thanks again for your help!