Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add option to use `ripgrep` for crawling the list of files #369
This PR contains some minimal changes to demonstrate the usage of
(the measurement has been done the same way as in #366).
The crawling behaviour with
Regarding 2., this change is quite noticeable, since the fuzzy finder currently displays the first 10 files returned by the crawler when it gets opened. This means that the first shown files will be slightly different than before (IMO we should change the default list of files that are shown when opening the fuzzy finder to show e.g recently opened files or currently opened files).
Other potential designs were presented here, and seems like
Regarding the current implementation, I've decided to use
changed the title
WIP: Add option to use `ripgrep` for crawling the list of files
Mar 12, 2019
referenced this pull request
Mar 12, 2019
Small update: I just realized that when using
This is quite slow (specially for large repos) so it gives us even greater performance improvements (we can reduce the times on large repos by another 50%
I consider this a huge improvement.
Thanks for listing these out. This seems promising and very much worth pursuing.
The testing so far seems to be going well:
A couple of drawbacks that I've discovered today:
@jasonrudolph any thoughts about these drawbacks?
Nice work, @rafeca!
This seems like a worthwhile tradeoff to me. We're trading a relatively tiny bit of additional disk space and bandwidth, and it turn we spend less time waiting for fuzzy-finder results.
We can generate a scopeless API token for our build account and use that token for atom/fuzzy-finder builds and atom/atom builds. Let's coordinate via Slack to make this happen.
Oh there's something else, this feature is behind a config param which is off by default. Since it's a fuzzy-finder config param, the setting is quite hidden and really hard to discover (you have to go to settings -> packages -> search fuzzy finder and click on its settings.
This is how this setting looks like:
I have mixed feelings about this:
Couple of things that we could do:
Another time we implemented an experimental setting was when we started using
Whenever people would open issues noting odd fuzzy finding behavior, we would ask them to try turning on the setting and reporting back. I think we can do the same thing here - keep the setting off by default, but advertise that the setting exists and will become the default in the near future (as we did for tree-sitter).
Looking back, what I think we could have done better is set a timeline for when to enable the new scoring method by default. As you can see, it's been three or four years, and I'm still not sure if it's enabled by default yet on all the packages that have it as an option. That was something we handled much better with tree-sitter.
I would opt towards making it off by default, advertising it when we can, and determining a target version to have it on by default. If by that target version it seems like it's still not ready for prime time, then we can re-evaluate.
@50Wliu that sounds good to me.
If I understand correctly our release cadence, if this PR lands now it'll get included in v1.37.0 which will be released around May. We could aim to enable it by default by v1.38.0 or v1.39.0 depending on the feedback/issues reported by users (this can be decided later though).
This was referenced
Mar 18, 2019
I love this idea! It doesn't need to be part of this PR, but I think it's worth trying in a follow-up PR. I'd be happy to help.
For what it's worth, I think it will be fairly straightforward to implement using the notification API.
Awesome! We can implement it as a followup