This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Do not call setItems() every time that the fuzzy finder is shown
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafeca
commented
Mar 28, 2019
| @@ -734,6 +747,9 @@ describe('FuzzyFinder', () => { | |||
| await projectView.toggle() | |||
|
|
|||
| expect(PathLoader.startTask).toHaveBeenCalled() | |||
|
|
|||
| await waitForReCrawlerToFinish(projectView) | |||
There was a problem hiding this comment.
There's a very small behaviour difference with this PR: before when adding or removing a project from the current Atom window the fuzzy finder was temporarily shown as empty while it was recrawling the new list of projects. Now, it displays the old results while the re-crawling happens (which is consistent with what happens when a new file is added/removed).
Before:
Now:
Based on its description, this test was not doing the assertion correctly: instead of checking that the end list of results was empty was just checking that the temporary loading window was empty (which also could cause some flakiness if the crawling happened faster than the time it takes to open the fuzzy finder), so I fixed it.
rafeca
changed the title
setItems() every time that the fuzzy finder is shown
With this commit, the Fuzzy finder will only call the setItems() method on its view whenever the items change (which happen whenever it re-crawls the filesystem). This commit will allow us to do more expensive operations on the setItems() phase without blocking the UI when toggling the fuzzy finder.
This common scenario was not covered and it's easy to cause a regression on it.
1 task
jasonrudolph
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR unblocks the work to use
native-fuzzyto improve the filtering performance by mitigating one of its concerns.Basically, before this PR the UI was blocked by the execution of the
setItems()method every time the fuzzy finder was shown (and it delayed its appearance in the UI). This was not a big problem before because thesetItems()method used to be quite fast, but with the addition ofnative-fuzzywe need to do more expensive things here (we need to serialize and pass the whole list of items to thenative-fuzzy).Alternate Designs
N/A
Benefits
Possible Drawbacks
N/A
Applicable Issues
#370