This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Pass credentials correctly when username is provided in the git URL #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryMuse
pushed a commit
that referenced
this pull request
Aug 1, 2017
Pass credentials correctly when username is provided in the git URL (cherry picked from commit 5b7c695)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
CredentialsDialogwas calling its submit callback with{username: '', password: 'whatever'}whenincludeUsernamewas false, which was causing our credential handler to stomp out the username that was provided originally.I've added some tests that catch this case, and omitted the
usernamekey from the result object ifincludeUsernameis true.Fixes #941.