Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix logic for automatically opening diff views based on selection change #1311
Problem: We’re seeing surprised diff views popping up unexpectedly, such as in the following scenarios
Scenario 1: see steps in #1287
These point to bugs in our logic for automatically opening diff views when the selection changes. We want to do this in two cases:
So let’s get clear on the circumstances under which we do want a pending diff item to be opened.
In order to get this behavior right, we need to get more specific around when/what/how exactly we want to automatically show the next file.
If there are stale pending pane items corresponding to a file that no
When? The following criteria must be satisfied
What? What parts of the workspace should be affected?
How? Implementation details for updating pending items according to what is outlined above
I've found one thing that looks like a typo which should probably be changed. Other than that, I'd say the rest of this PR is ready to