Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Yet Another Test Flake #1320

Merged
merged 8 commits into from
Feb 24, 2018
Merged

Yet Another Test Flake #1320

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0dc7caf
I know I've seen this one fail recently
kuychaco Feb 23, 2018
f95b585
focus
smashwilson Feb 24, 2018
1be16ae
console.logs for the console.log throne
smashwilson Feb 24, 2018
f7130a4
Was that cache entry just not being cleared yet?
smashwilson Feb 24, 2018
7796da2
The Array index shuffle
smashwilson Feb 24, 2018
5893090
:fire: `console.log()` :fire:
smashwilson Feb 24, 2018
c0b566b
:fire: `it.stress()` :fire:
smashwilson Feb 24, 2018
ed00d6e
Merge branch 'master' into workdir-cache-flake
smashwilson Feb 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/models/workdir-cache.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,13 @@ describe('WorkdirCache', function() {
Array(6).fill(null, 0, 6).map(() => cloneRepository('three-files')),
);

await Promise.all(dirs.map(dir => cache.find(dir)));
const expectedDir = dirs[1];
await Promise.all(dirs.slice(0, 5).map(dir => cache.find(dir)));
await cache.find(dirs[5]);

const expectedDir = dirs[2];
sinon.spy(cache, 'revParse');
const actualDir = await cache.find(expectedDir);
assert.equal(actualDir, expectedDir);
assert.strictEqual(actualDir, expectedDir);
assert.isTrue(cache.revParse.called);
});
});