Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Remove "(preview)" from GitHub tab title #1602

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 20, 2018

Description of the Change

This removes the "(preview)" in the tab title.

Before After
screen shot 2018-07-20 at 3 19 24 pm screen shot 2018-07-20 at 3 18 44 pm

Benefits

  • With the recent changes, might be time to remove the "beta" label.
  • More space for other tabs (depends a bit on the theme).
  • Less cluttered UI

Possible Drawbacks

None

Applicable Issues

None

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage decreased (-0.08%) to 79.546% when pulling 070583a on sm/remove-preview into 397e431 on master.

@annthurium
Copy link

oh, did "preview" mean beta? I thought it meant this was a preview of what the pull request would look like on dotcom.

anyway yeah, definitely seems like time to remove it!

@simurai
Copy link
Contributor Author

simurai commented Jul 21, 2018

I thought it meant this was a preview of what the pull request would look like on dotcom.

Ohh.. you might be right. I always thought "preview" means "it's not finished and there will be more". 😅

@Arcanemagus
Copy link

040acf7

Since the previous word was alpha, I'd say it's a pretty safe bet that the word was meant as a status of the package, not the tab 😉.

@smashwilson smashwilson merged commit 1a05be8 into master Aug 9, 2018
@smashwilson smashwilson deleted the sm/remove-preview branch August 9, 2018 18:53
@smashwilson
Copy link
Contributor

Sure, why not. :shipit:

@annthurium
Copy link

bitmoji

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants