Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "(preview)" from GitHub tab title #1602

Merged
merged 2 commits into from Aug 9, 2018

Conversation

5 participants
@simurai
Copy link
Member

simurai commented Jul 20, 2018

Description of the Change

This removes the "(preview)" in the tab title.

Before After
screen shot 2018-07-20 at 3 19 24 pm screen shot 2018-07-20 at 3 18 44 pm

Benefits

  • With the recent changes, might be time to remove the "beta" label.
  • More space for other tabs (depends a bit on the theme).
  • Less cluttered UI

Possible Drawbacks

None

Applicable Issues

None

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage decreased (-0.08%) to 79.546% when pulling 070583a on sm/remove-preview into 397e431 on master.

@annthurium

This comment has been minimized.

Copy link
Contributor

annthurium commented Jul 20, 2018

oh, did "preview" mean beta? I thought it meant this was a preview of what the pull request would look like on dotcom.

anyway yeah, definitely seems like time to remove it!

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Jul 21, 2018

I thought it meant this was a preview of what the pull request would look like on dotcom.

Ohh.. you might be right. I always thought "preview" means "it's not finished and there will be more". 😅

@Arcanemagus

This comment has been minimized.

Copy link

Arcanemagus commented Jul 23, 2018

040acf7

Since the previous word was alpha, I'd say it's a pretty safe bet that the word was meant as a status of the package, not the tab 😉.

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Jul 30, 2018

@smashwilson smashwilson merged commit 1a05be8 into master Aug 9, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.08%) to 79.546%
Details

Stability Sprint : 23 July - 3 August 2018 : v0.19.0 automation moved this from In Progress 🔧 to Merged ☑️ Aug 9, 2018

@smashwilson smashwilson deleted the sm/remove-preview branch Aug 9, 2018

@smashwilson

This comment has been minimized.

Copy link
Member

smashwilson commented Aug 9, 2018

Sure, why not. :shipit:

@annthurium

This comment has been minimized.

Copy link
Contributor

annthurium commented Aug 9, 2018

bitmoji

This was referenced Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.