Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fill out the build matrix #1663

Merged
merged 12 commits into from
Aug 24, 2018
Merged

Fill out the build matrix #1663

merged 12 commits into from
Aug 24, 2018

Conversation

smashwilson
Copy link
Contributor

Our CI builds test against:

  • CircleCI (macOS): Atom stable only
  • AppVeyor (Windows): Atom stable and beta
  • Travis (Linux): Atom stable, beta, and dev

I'm fleshing out the build matrix so that we test against all three channels on all three platforms.

@smashwilson smashwilson added this to In Progress 🔧 in Feature Sprint : 27 August - 14 September 2018 : v0.20.0 via automation Aug 23, 2018
@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage decreased (-0.08%) to 80.132% when pulling 73df8c5 on aw/full-matrix into f29c93f on master.

@smashwilson
Copy link
Contributor Author

Ahhhh:

smashwilson @ hubtop ~/src/atom/github (aw/full-matrix *=) [1]
$ CIRCLECI=true atom --enable-electron-logging --test test/
[46488:0823/154605.721511:WARNING:dns_config_service_posix.cc(156)] dns_config has unhandled options!
[46488:0823/154607.349484:INFO:CONSOLE(17286)] "%cDownload the React DevTools for a better development experience: https://fb.me/react-devtools
You might need to use a local HTTP server (instead of file://): https://fb.me/react-devtools-faq", source: /Users/smashwilson/src/atom/github/node_modules/react-dom/cjs/react-dom.development.js (17286)
[46488:0823/154607.403865:INFO:CONSOLE(119)] "Error: Cannot find module 'mocha'
    at Module._resolveFilename (module.js:543:15)
    at Module._resolveFilename (/Applications/Atom Nightly.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._resolveFilename (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/module-cache.js:350:52)
    at Function.Module._load (module.js:473:25)
    at Module.require (module.js:586:17)
    at require (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/native-compile-cache.js:47:27)
    at Object.<anonymous> (/Users/smashwilson/src/atom/github/node_modules/mocha-multi-reporters/lib/MultiReporters.js:13:13)
    at Object.<anonymous> (/Users/smashwilson/src/atom/github/node_modules/mocha-multi-reporters/lib/MultiReporters.js:182:3)
    at Module._compile (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/native-compile-cache.js:87:30)
    at Object.value [as .js] (/Users/smashwilson/src/atom/atom/src/compile-cache.js:235:23)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/native-compile-cache.js:47:27)
    at Object.<anonymous> (/Users/smashwilson/src/atom/github/node_modules/mocha-multi-reporters/index.js:2:22)
    at Object.<anonymous> (/Users/smashwilson/src/atom/github/node_modules/mocha-multi-reporters/index.js:6:3)
    at Module._compile (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/native-compile-cache.js:87:30)
    at Object.value [as .js] (/Users/smashwilson/src/atom/atom/src/compile-cache.js:235:23)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/native-compile-cache.js:47:27)
    at module.exports.mocha (/Users/smashwilson/src/atom/github/test/runner.js:100:20)
    at runTests (/Users/smashwilson/src/atom/github/node_modules/atom-mocha-test-runner/lib/create-runner.js:83:21)
    at /Users/smashwilson/src/atom/github/node_modules/atom-mocha-test-runner/lib/create-runner.js:98:9
    at new Promise (<anonymous>)
    at /Users/smashwilson/src/atom/github/node_modules/atom-mocha-test-runner/lib/create-runner.js:89:12
    at module.exports (/Applications/Atom Nightly.app/Contents/Resources/app.asar/src/initialize-test-window.js:98:17)", source: /Users/smashwilson/src/atom/github/node_modules/@smashwilson/atom-mocha-test-runner/lib/create-runner.js (119)

It looks like the npm upgrade "broke" this - or, rather, revealed that it shouldn't have been working to begin with. mocha-multi-reporters does a require('mocha'), but because we don't depend directly on mocha but as a transitive dependency of @smashwilson/atom-mocha-test-runner, the require no longer resolves:

$ find node_modules -name mocha
node_modules/@smashwilson/atom-mocha-test-runner/node_modules/.bin/mocha
node_modules/@smashwilson/atom-mocha-test-runner/node_modules/mocha
node_modules/@smashwilson/atom-mocha-test-runner/node_modules/mocha/bin/mocha

@smashwilson smashwilson merged commit 920acf1 into master Aug 24, 2018
Feature Sprint : 27 August - 14 September 2018 : v0.20.0 automation moved this from In Progress 🔧 to Merged ☑️ Aug 24, 2018
@smashwilson smashwilson deleted the aw/full-matrix branch August 24, 2018 12:51
@smashwilson smashwilson added the ci label Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants