Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add metrics collection for committing partial changes, undoing the last commit, and opening an expanded commit msg editor #1685
Description of the Change
This PR introduces some of the additional metrics discussed in #1591.
So far I've added events for the following:
Other thoughts and considerations:
Expanded commit message editor usage
Gathering data on button use vs. keyboard shortcuts vs. context menu use
To gather information on partial-staging I considered tracking staging/unstaging events. At the end of the day though, I think what we care most about is how frequently users are taking advantage of the fact that you can easily make commits with partial changes using our UI. Tracking all of the staging/unstaging events seems like it would be a lot of noise with little additional value. Open to thoughts and suggestions though!
We'll have interesting insights into user behavior, and be able to ask/answer questions such as those above in italics. This information could potentially help us identify UX issues, inform project decisions and priorities, and track the impact of future work and features introduced.
This PR simply introduces additional metrics collection. No drawbacks that I can think of.
overall, looks good! Thanks for diving in on this. Left a few comments in the code.
a few more thoughts on the questions you raised in the body of the pull request:
Regarding gathering metrics on expanded commit editor usage, if we do choose to do so
You can also use a command, so the optimal location to instrument would be the
Yeah, that and/or there’s potential to improve discoverability :)