Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

v0.21.0-0 QA Review #1752

Closed
7 tasks done
annthurium opened this issue Oct 20, 2018 · 3 comments
Closed
7 tasks done

v0.21.0-0 QA Review #1752

annthurium opened this issue Oct 20, 2018 · 3 comments
Labels
quality Quality assurance pass checklist for a prerelease version

Comments

@annthurium
Copy link
Contributor

annthurium commented Oct 20, 2018

Here are all the PRs going out in this release. Let's test them.

I'm excluding PRs that only touch docs or tests, since we had a few of those.

@annthurium annthurium added the quality Quality assurance pass checklist for a prerelease version label Oct 20, 2018
@kuychaco
Copy link
Contributor

kuychaco commented Oct 22, 2018

For #1713 the commit message contents do not update when a merge conflict is initiated (expectation is that the merge conflict message would show up), or when the merge is aborted (expectation is that commit message template gets displayed). Note that these need not be fixed before the release.

@annthurium
Copy link
Contributor Author

annthurium commented Oct 22, 2018

@kuychaco I also noticed that #1713, if you delete all the text in the commit message box, it stays deleted until Atom window is refreshed. That might be something we want to address in the future but I don't think it's a release blocker.

@kuychaco
Copy link
Contributor

Ended up reverting #1713. We'll fix the regression associated with it and get it into the next release

I also noticed that #1713, if you delete all the text in the commit message box, it stays deleted until Atom window is refreshed

@annthurium mind providing repro steps for this? Not quite sure what you mean

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quality Quality assurance pass checklist for a prerelease version
Projects
None yet
Development

No branches or pull requests

2 participants