Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix GitHub Package Tests #2315
Description of the Change
This will slow down test, because we were previously not preventing state leak.
#2308 Ran into trouble implementing good test cases, because state leak was corrupting the results.
I fixed 'em
Updated test case accuracy.
smashwilson left a comment
Major kudos for taking this on
How are we doing on test coverage so far? This is one of the suites that didn't have great test coverage in the past (and that's even more of a pain to bring up to date after the fact
I see you've still got the last commented-out bit left to do - re-request review from me when you're ready and we'll get this in
It doesn't seem super awful. I have not covered any new branches though, as I was just updating the old code.
Also, the failed test case was not me it was a flake.