Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

autocomplete also completes type and causes invalid java #10

Closed
ungb opened this issue Sep 12, 2017 · 3 comments
Closed

autocomplete also completes type and causes invalid java #10

ungb opened this issue Sep 12, 2017 · 3 comments

Comments

@ungb
Copy link

ungb commented Sep 12, 2017

When you autocomplete a method in java, it seems to print the type with it as well which causes invalid java.

see gif:
type

Version:

├── atom-clock@0.1.15
├── atom-ide-ui@0.3.0
├── bracket-matcher@0.87.3
├── chester-atom-syntax@0.3.0
├── chestnut-light-atom-syntax@0.2.1
├── docks-test@0.0.0 (disabled)
├── github@0.5.1
├── ide-java@0.6.0
├── language-typescript-grammars-only@1.6.0 (disabled)
├── preview-inline@1.4.7
├── pure-syntax@0.3.0
└── tree-view@0.217.7

/CC @damieng

@fbricon
Copy link
Contributor

fbricon commented Sep 12, 2017

@damieng when a completion is selected, you should call completionItem/resolve. At the very least you should insert CompletionItem.insertText instead of the label

@damieng
Copy link
Contributor

damieng commented Sep 12, 2017

We are using insertText when it is present and only falling back to label where it is not.

Unfortunately our autocomplete-plus package does not have a resolve-type event yet.

@damieng
Copy link
Contributor

damieng commented Sep 25, 2017

@ungb Are you still able to repro this with the latest version? If so can we pair and check out the protocol messages?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants