Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Allow folding switch_default #644

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Allow folding switch_default #644

merged 1 commit into from
Apr 10, 2019

Conversation

Ben3eeE
Copy link
Contributor

@Ben3eeE Ben3eeE commented Apr 3, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

case statements in javascript are parsed as:
switch_statement > switch_body >switch_case

Default case statements in javascript are parsed as:
switch_statement >switch_body > switch_default

This PR adds switch_default to the folding rules so default can be folded with the same rule as case.

Alternate Designs

N/A

Benefits

Consistent folding rules for switch statements

Possible Drawbacks

Someone likes unfoldable default and will open an issue that they can now fold it

Applicable Issues

N/A

Verification Process

const fun = () => {
  switch (variable) {
    case DO_STUFF:
      do_stuff();
      break;
    case DO_OTHER_STUFF:
      do_other_stuff();
      test();
      break;
    default:
      do_stuff();
      test();
      break;
  }
};
  • Can not fold the default before this change
  • Can fold the default after this change
  • Run editor:log-cursor-syntax-tree-scope in the default and the switch to verify that they are parsed differently

@nathansobo nathansobo self-assigned this Apr 10, 2019
@nathansobo
Copy link
Contributor

❤️ This will be nice.

@nathansobo nathansobo merged commit 6e90f7b into master Apr 10, 2019
@Ben3eeE Ben3eeE deleted the b3-fold-default branch April 11, 2019 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants