Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Possibility of adding support for iOS and Android #42

Closed
jg123 opened this issue Jun 24, 2016 · 2 comments
Closed

Possibility of adding support for iOS and Android #42

jg123 opened this issue Jun 24, 2016 · 2 comments
Labels

Comments

@jg123
Copy link

jg123 commented Jun 24, 2016

How possible would it be to add support for the iOS keychain and the Android keystore by way of react-native?

@shiftkey
Copy link
Contributor

I'm honestly not sure how React Native handles native Node modules, and a quick skim of some resources didn't really help me to understand further.

If someone knows how to do it, I'd love to hear more and see what's possible.

@shiftkey
Copy link
Contributor

@jg123 I'm going to close this out as I don't believe I can support this in keytar for a few reasons:

  • the examples for iOS and Android are written in Java and ObjectiveC, which are different to the plain C++ we have currently in the project
  • we leverage nan in a lot of places to make cross-platform support consistent, but it looks like native modules in React Native requires handrolling a lot of platform-specific code for interop
  • the toolchain for supporting this is very different to what we support in keytar - instead of using node-gyp and a binding.gyp, you need to setup Gradle and XCode projects to build for each platform
  • this isn't an area I'm familiar with, and don't have bandwidth to skill up on in the near future

If someone however wants to take a shot at this to see if they can get something working, go for it. But I don't think we can leverage much of what's in here to target React Native, which seems to be where the initial question was heading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants