New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw when attempting to parse URLs #106

merged 2 commits into from Nov 21, 2017


None yet
1 participant

50Wliu commented Nov 21, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Silently catch the error instead.

Alternate Designs



Less errors.

Possible Drawbacks


Applicable Issues

Fixes atom/atom#16252.

50Wliu added some commits Nov 21, 2017

@50Wliu 50Wliu merged commit edd73d9 into master Nov 21, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded

@50Wliu 50Wliu deleted the wl-handle-undefined-url branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment