Build error when building against Electron 7 on Linux

[DeeDeeG]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Compilation error:

../src/scrollbar-style-observer-non-mac.cc: In static member function ‘static void ScrollbarStyleObserver::Init(v8::Local<v8::Object>)’:
../src/scrollbar-style-observer-non-mac.cc:35:51: error: no matching function for call to ‘v8::Object::Set(v8::Local<v8::String>, v8::Local<v8::Function>)’
     Nan::GetFunction(newTemplate).ToLocalChecked());
                                                   ^

See: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=886&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=cccdf131-0893-5d7b-ccea-9ccfc8953f95&l=889

Steps to Reproduce

1. Modify Atom master branch to depend on to depend on this package, version 3.2.2
2. Modify Atom master branch to use Electron version 7.3.3
3. On Linux, try to build Atom

Expected behavior:

Atom should build successfully

Actual behavior:

scrollbar-style fails to compile during Atom's bootstrap process

Reproduces how often:

100%

Versions

Info from (unaffected, succesfully built) macOS app:

% ~/atom/out/Atom\ Dev.app/Contents/MacOS/Atom\ Dev --version   
Atom    : 1.55.0-dev-689759bb5
Electron: 7.3.3
Chrome  : 78.0.3904.130
Node    : 12.8.1

% ~/atom/out/Atom\ Dev.app/Contents/Resources/app/apm/bin/apm --version
apm  2.5.2-atomic.3.1
npm  6.14.9
node 12.4.0 x64
atom 1.55.0-dev-689759bb5
python 2.7.16
git 2.27.0

Reproduced on OS: Ubuntu 16.04 (CI) and Ubuntu 20.04 (not CI)

Additional Information

Seems like there is a NAN issue that is triggered on non-mac OSes, perhaps just on Linux.

[DeeDeeG]

@sadick254 sorry to bother you, but perhaps you would be interested in this? I notice you were able to solve some NAN-related issues in this and other packages recently. Not sure who else to ping. Thank you.

[sadick254]

@DeeDeeG Thank you for opening an issue. I have seen this failure when building on newer electron versions. I will look into it. It's not a bother, you are reporting a valid issue.