This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Convert method names to snake_case #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 15, 2017 07:09
nathansobo
force-pushed
the
snake-case-functions
branch
from
08a3a45
to
cd04812
Compare
|
Is it a typo, or did you also want to change the case of some bound methods (cf here)? It will very probably be at odd with the rest of any code that will use this library. |
|
Yeah, thanks for the heads-up. That was indeed an oversight when I renamed everything in the file. We fixed it on master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CapitalizedCamelCase naming convention we originally adopted to blend in with V8 APIs is driving me nuts. This is the convention Tree Sitter uses and just feels better to me. I'd even consider lower-casing class names to blend in perfectly with the STL, but this seems like a less controversial first step.
/cc @maxbrunsfeld