Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

data-path attribute doesn't match pattern in other packages #79

Closed
lee-dohm opened this issue Aug 26, 2014 · 3 comments
Closed

data-path attribute doesn't match pattern in other packages #79

lee-dohm opened this issue Aug 26, 2014 · 3 comments

Comments

@lee-dohm
Copy link
Contributor

The packages in question are tree-view, fuzzy-finder and tabs. All three have places where they display filenames with data-name and data-path attributes. In tree-view and fuzzy-finder, the data-path attribute is populated with the relative path of the file. The data-path attribute is populated with the absolute path to the file in the tabs package.

@kevinsawicki
Copy link
Contributor

@lee-dohm any preference whether the path should be relative or absolute?

My gut says absolute provides the most flexibility since you can match more in your stylesheet based on knowing the full path.

@lee-dohm
Copy link
Contributor Author

Yeah, I agree that absolute is probably the most flexible. I don't really have a preference as either should work for my purposes. Should I close this and open issues on tree-view and fuzzy-finder?

@kevinsawicki
Copy link
Contributor

Should I close this and open issues on tree-view and fuzzy-finder?

That sounds good, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants