Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add newly opened buffers when not following host #274

Closed
IbisLiven opened this issue Dec 12, 2017 · 4 comments
Closed

Add newly opened buffers when not following host #274

IbisLiven opened this issue Dec 12, 2017 · 4 comments

Comments

@IbisLiven
Copy link

IbisLiven commented Dec 12, 2017

  • [] Put an X between the brackets on this line if you have done all of the following:

Description

When a guest is following the host, any new buffers the host opens are added to the guest's workspace as a remote buffer. However if the guest isn't following the host (the guest is looking at different remote buffer, the host is following the guest instead, ...), any new buffers added by the host aren't added to the guest's workspace.

Could a change be made to add all the buffers the host opens while sharing a portal to every guest's workspace? or is this there a reason that this isn't the current behaviour? (i don't know if this is a feature or a bug, or just something overlooked)

Steps to Reproduce

  1. Host opens portal
  2. guest joins portal
  3. guest stops following host (opening another file, opening a different remote buffer from the one the host is looking at, host is following guest instead, ...)
  4. host opens new buffer

Expected behavior:
When guest is following host: new buffers added by host are added to the guest's workspace
(guest is switched to whatever host is looking at)
When guest it not following host: new buffers added by host are added to the guest's workspace
(guest is not switched to whatever host is looking at)

Actual behavior:
When guest is following host: new buffers added by host are added to the guest's workspace
(guest is switched to whatever host is looking at)
When guest it not following host: new buffers added by host are not added to the guest's workspace
(guest is not switched to whatever host is looking at)

Reproduces how often:
100%

Versions

Atom: 1.23.0
Electron: 1.6.15
Chrome: 56.0.2924.87
Node: 7.4.0
Teletype 0.3.0

Additional Information

@jasonrudolph
Copy link
Contributor

Could a change be made to add all the buffers the host opens while sharing a portal to every guest's workspace? or is this there a reason that this isn't the current behaviour? (i don't know if this is a feature or a bug, or just something overlooked)

We're currently working on RFC-001 (tracked in #268) which will offer the ability for guests to use the fuzzy-finder to open any buffer that's present in the host's workspace. Our current thinking is that if you're not following the host, you probably don't want new tabs appearing in your editor every time the host opens a new buffer. Instead, you can re-follow the host to view/open their current buffer, and once RFC-001 is fully implemented, you'll also be able to use the fuzzy-finder to open any other buffers that the host has shared.

Once RFC-001 is implemented, if there are use cases you have in mind that aren't solved by following the host or by using the fuzzy finder, we'd love to hear about those use cases.

@CaptainJohnyAppleSeed
Copy link
Contributor

CaptainJohnyAppleSeed commented Mar 14, 2018

I'm not sure if RFC-001 completely handled this issue. Following the above reproduction steps, I was unable to use the fuzzy-finder to get the remote file. In the picture, the host (right) has a file open, CompileOS and shared that the guest (left) cannot access using the fuzzy-finder.
screen shot 2018-03-14 at 1 48 55 am

@jasonrudolph
Copy link
Contributor

@CaptainJohnyAppleSeed: RFC-001's fuzzy-finder integration is dependent on fuzzy-finder v1.8.0 which will be included in Atom 1.26.

Keep an eye out for a beta release of Atom 1.26 soon. 😄

@jasonrudolph
Copy link
Contributor

With the updates in teletype v0.10.0 and fuzzy-finder v1.8.0, we think we've addressed the needs described in this issue, so I'm going to close this out.

Thanks for opening this issue, @IbisLiven. 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants