Identify Portal Participants

[jasonrudolph]

For the very first step on the road to authentication and presence [1] [2], we'll enhance the package to identify all participants in the portal.

Behavior

This initial staff-ship will provide the following behavior:

• As a user, when I attempt to share or join a portal, and the real-time package does not yet have a GitHub OAuth token for me, the package prompts me to obtain a token and paste that token into Atom (Authentication #87)
• As a host, when a guest joins my portal, I see a notification saying, "@<guest-username> has joined your portal" [3] (Authentication #87)
• As a guest, when I join a portal, I see a notification saying, "You're now collaborating with @<host-username>" [3]
• As a guest, when another guest joins the portal, I see a notification saying, "@<guest-username> has joined the portal" [3]

TODO

This is a partial task list, largely intended to help me keep track of things going on across various repositories 😄. We'll know that everything is actually done when the package provides the behavior described above. ☝️

• Add OAuth flow to atom.io for real-time package (https://github.com/github/atom.io/pull/1183)
• Add "happy path" authentication logic to real-time-server (Authentication, Part 1 teletype-server#4)
• End-to-end happy path with real-time package reading OAuth token from env var
• Store/fetch OAuth token to/from keytar
• Address all TODO comments introduced in Authentication, Part 1 teletype-server#4
• Integrate authentication into real-time-client
• Handle failure cases in real-time package
  • OAuth token not valid
  • GitHub API rate limit exceeded
  • GitHub API inaccessible
• Add DNS entry for tachyon.atom.io (https://github.com/github/dns/pull/722)
• Add CI for real-time-server, now that it has tests (✨ Set up CI ✨ teletype-server#5)

---

[1] Portals roadmap
[2] Buddy list exploration
[3] We'll likely tweak the copy before shipping ✨

[nathansobo]

I really love your organized mind.

[jasonrudolph]

#87 accomplishes most of what we outlined in the issue body above. 🤘

@as-cii @nathansobo: Do you think we should pursue the remaining items, or would you want to hold off on those items until we implement something like the buddy list UI we've been discussing?

[nathansobo]

I think we may as well finish the notifications and ensure our error handling is good before proceeding.

[as-cii]

I think we already show an error when something goes wrong when authenticating. As for notifications, the only one we haven't implemented is:

As a guest, when I join a portal, I see a notification saying, "You're now collaborating with @" [3]

It should be pretty straightforward to add, but I am not sure we need it since guest users knows who they are connecting to. I am open to adding it, but I think we should go ahead and staff-ship what we have currently. Thoughts? 💭

[jasonrudolph]

As a guest, when I join a portal, I see a notification saying, "You're now collaborating with @" [3]

It should be pretty straightforward to add, but I am not sure we need it since guest users knows who they are connecting to.

We discussed this on our planning call today and agreed that we should skip this ☝️ for now.

With that in mind, I'm gonna close this issue.

/xref https://github.com/github/atom-log/commit/14587eb1e7e2c3ee9aaf54de11c559884b4e75aa#diff-354c56c08bc3626e67f6ba3f207a7920R66