This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Authentication #87
Merged
Authentication #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we will instantiate a `GithubAuthenticationProvider` with the keytar-backed password manager.
Don't assume we're storing one password and allow the password's key to be assigned in the GithubAuthenticationProvider
@as-cii, I decided the less abstract name of "auth token provider" helps tell the story of this dependency more clearly. It provides an auth token. It does this by authenticating. I think both are valid but being more concrete just feels clearer to me here. Open to discussing it if you disagree.
Since we're storing tokens, which aren't *strictly* passwords
For some unexplained reason, keytar is throwing exceptions on some machines with unsigned builds. In this case, we shell out to the security binary on macOS or just store things in memory otherwise.
* Present a link instead of opening the token generation page automatically * Don't throw errors when the dialog is dismissed * Present an error message and allow retries when tokens are invalid Also, we extract a login-dialog etch component.
as-cii
force-pushed
the
authentication-2
branch
from
468749c
to
3649a67
Compare
added 2 commits
September 29, 2017 12:12
This overrides the `text-align: center` style that is applied to the entire LoginDialog and prevents TextEditor from positioning the cursor in weird locations.
|
This is ready to go. I will go ahead and merge this after lunch. |
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on atom/teletype-server#20
Depends on atom/teletype-client#18
This pull-request brings GitHub authentication into the real-time package. In particular, sharing and joining a portal will now require visiting tachyon.atom.io first to retrieve an OAuth token, which can then be copy-pasted into Atom to start using the real-time package:
(Please, note that we only require the password once or in the case the token becomes invalid).
When a user joins or leaves a portal, all the participants receive a notification showing the username of the person who joined/left:
Our ultimate goal for the user experience revolving around authentication is to show something like the buddy list proposed by @simurai in #22, but this provides a first MVP that allows us to ship the package with authentication, so that later on we can just iterate on the UX.
/cc: @nathansobo @jasonrudolph