Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add support for multiple root folders #368

Merged
merged 12 commits into from
Feb 19, 2015
Merged

Conversation

maxbrunsfeld
Copy link
Contributor

Refs atom/atom#770.

  • Add command & context menu item for adding a new root folder
  • Render multiple root folders
  • Make sure all commands work correctly with multiple root folders
    • tree-view:reveal-active-file
    • tree-view:paste
    • tree-view:add-file
    • tree-view:add-folder
  • Make sure all git-integrations work properly w/ multiple repos
    • copy dialog
    • add dialog
    • move dialog
    • git status colors
  • Don't make the code uglier.

@maxbrunsfeld maxbrunsfeld force-pushed the mb-multiple-root-folders branch 2 times, most recently from 4d86290 to ae450a2 Compare February 18, 2015 19:48
@@ -39,6 +39,7 @@
{'label': 'Split Right', 'command': 'tree-view:open-selected-entry-right'}
{'type': 'separator'}

{'label': 'Add Root Folder', 'command': 'tree-view:add-root-folder'}
{'label': 'Copy Full Path', 'command': 'tree-view:copy-full-path'}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atom/core Does anyone have an opinion about the naming of this command and the renaming of the two above? We thought Add Folder seemed too similar to Add Root Folder, so we renamed it to New Folder, and did the same for File.

I thought about renaming the actual commands too, but I held off because I didn't want to break people's key-bindings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like your idea of having "add folder" mean "add a new root folder" and "new folder" mean "create a new folder in this location".

maxbrunsfeld pushed a commit that referenced this pull request Feb 19, 2015
Add support for multiple root folders
@maxbrunsfeld maxbrunsfeld merged commit da54b49 into master Feb 19, 2015
@maxbrunsfeld maxbrunsfeld deleted the mb-multiple-root-folders branch February 19, 2015 00:57
@nathansobo
Copy link
Contributor

You are cranking sir.

@craighooghiem
Copy link

Would be great if we could also add new root folders even if they are a child folder of the existing root folder. Handy for adding asset folders, library directories, etc.

@mrameezraja
Copy link

Is it possible to have a solution of projects in atom like Visual Studio ?

@maxbrunsfeld
Copy link
Contributor Author

@mrameezraja We do eventually want to add some kind of project file feature, but we're not sure yet how exactly we want it to work. If you have ideas, please add them on this issue: atom/atom#5728.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants