Skip to content
This repository has been archived by the owner on Aug 12, 2019. It is now read-only.

Welcome adds time to startup, even though it is never expected to be used again #14

Closed
abovethewater opened this issue Apr 3, 2014 · 1 comment

Comments

@abovethewater
Copy link

Welcome claims to display a:

Welcome editor when Atom is opened for the first time

I've now used atom for a few weeks, and going through some packages today I saw:

This package added 3ms to startup time.

I've now disabled it to save myself those critical 3ms, but suggest that Welcome should auto disable after 1st launch.

Yes, this goes against

If you ever want to see this buffer again...

But the most useful thing about that message is the key combo for cmd-shift-p, which you need to remember anyhow to be able to get the message up again.
Maybe move the buffer to the package description so it doesn't need enabling to be able to find it again.

One for thought, fell free to close as wont-fix

Loving atom

@kevinsawicki
Copy link
Contributor

Thanks for bringing this up, it is always useful to profile where this time is spent and work on speeding up the core package loading time, since nothing specific in the welcome package's code actually eats up this 3ms. It looks like it is purely the loading of package resources, i.e menus, keymaps, and stylesheets. Even though this package has none of those, it still takes some measurable time looking for them on disk.

I'm going to spend some more time profiling the core package loader and seeing if there are any speedups we can do there to benefit all packages. But I don't think auto-disabling this package after first launch is the right approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants