-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#25 tables ontology #612
#25 tables ontology #612
Conversation
lib/defaults/table.json
Outdated
{ | ||
"@id": "https://atomicdata.dev/properties/color", | ||
"https://atomicdata.dev/properties/datatype": "https://atomicdata.dev/datatypes/string", | ||
"https://atomicdata.dev/properties/description": "The color of something.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs specification e.g.. css Color
or rgb hex with alpha
lib/defaults/table.json
Outdated
}, | ||
{ | ||
"@id": "https://atomicdata.dev/classes/FormattedNumber", | ||
"https://atomicdata.dev/properties/description": "A number that should be displayed in a certain way.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add an example here
lib/defaults/table.json
Outdated
"https://atomicdata.dev/properties/shortname" | ||
], | ||
"https://atomicdata.dev/properties/shortname": "date-format", | ||
"https://atomicdata.dev/properties/subresources": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is useful, but maybe it should be a different relationship than subresource. Not sure.
lib/defaults/table.json
Outdated
"https://atomicdata.dev/properties/shortname" | ||
], | ||
"https://atomicdata.dev/properties/shortname": "number-format", | ||
"https://atomicdata.dev/properties/subresources": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Perpaps examples
?
lib/defaults/table.json
Outdated
"https://atomicdata.dev/properties/min", | ||
"https://atomicdata.dev/properties/max" | ||
], | ||
"https://atomicdata.dev/properties/requires": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need empty arrays
lib/defaults/table.json
Outdated
}, | ||
{ | ||
"@id": "https://atomicdata.dev/classes/Tag", | ||
"https://atomicdata.dev/properties/description": "A tag describes a an enum attribute of a resource.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (a an)
lib/defaults/table.json
Outdated
}, | ||
{ | ||
"@id": "https://atomicdata.dev/classes/FloatRangeProperty", | ||
"https://atomicdata.dev/properties/description": "A property who's float value is contained by a min and/or max size.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whose
lib/defaults/table.json
Outdated
"https://atomicdata.dev/properties/minFloat", | ||
"https://atomicdata.dev/properties/maxFloat" | ||
], | ||
"https://atomicdata.dev/properties/requires": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emptry arr
PR Checklist: