Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25 tables ontology #612

Merged
merged 4 commits into from
Mar 11, 2023
Merged

#25 tables ontology #612

merged 4 commits into from
Mar 11, 2023

Conversation

Polleps
Copy link
Member

@Polleps Polleps commented Mar 10, 2023

PR Checklist:

@joepio joepio changed the title #25 tables #25 tables ontology Mar 10, 2023
{
"@id": "https://atomicdata.dev/properties/color",
"https://atomicdata.dev/properties/datatype": "https://atomicdata.dev/datatypes/string",
"https://atomicdata.dev/properties/description": "The color of something.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs specification e.g.. css Color or rgb hex with alpha

},
{
"@id": "https://atomicdata.dev/classes/FormattedNumber",
"https://atomicdata.dev/properties/description": "A number that should be displayed in a certain way.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add an example here

"https://atomicdata.dev/properties/shortname"
],
"https://atomicdata.dev/properties/shortname": "date-format",
"https://atomicdata.dev/properties/subresources": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful, but maybe it should be a different relationship than subresource. Not sure.

"https://atomicdata.dev/properties/shortname"
],
"https://atomicdata.dev/properties/shortname": "number-format",
"https://atomicdata.dev/properties/subresources": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Perpaps examples?

"https://atomicdata.dev/properties/min",
"https://atomicdata.dev/properties/max"
],
"https://atomicdata.dev/properties/requires": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need empty arrays

},
{
"@id": "https://atomicdata.dev/classes/Tag",
"https://atomicdata.dev/properties/description": "A tag describes a an enum attribute of a resource.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (a an)

},
{
"@id": "https://atomicdata.dev/classes/FloatRangeProperty",
"https://atomicdata.dev/properties/description": "A property who's float value is contained by a min and/or max size.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whose

"https://atomicdata.dev/properties/minFloat",
"https://atomicdata.dev/properties/maxFloat"
],
"https://atomicdata.dev/properties/requires": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptry arr

@joepio joepio merged commit 9dbcd34 into develop Mar 11, 2023
@joepio joepio deleted the #25-tables branch March 11, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants