Add dryRun flag to CodeTransform invocations #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdupuis
added
changelog:added
ddgenome
reviewed
Dec 11, 2018
| `Code transform ${italic(editorName)} made no changes to ${bold(slug)}`)); | ||
| } else if (isDryRun(params)) { | ||
| const gitDiffResult = await execPromise("git", ["diff"], { cwd: project.baseDir }); |
There was a problem hiding this comment.
Should probably wrap in a try/catch block to be safe.
cdupuis
force-pushed
the
code-transform-dry-run
branch
from
1cd85ab
to
0dc8340
Compare
cdupuis
force-pushed
the
code-transform-dry-run
branch
from
9befa81
to
6d49b8a
Compare
johnsonr
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to the invocation of
CodeTransforms: When specifieddryRun=truethe transform will not commit its changes and instead the git diff will get sent back to the person invoking the command.This is useful for testing transforms across a large set of the repos.
Oh, and cleaned up a couple of unused imports.