Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Preferences shortcut, "Shortcuts" window name/title #61

Open
RedBearAK opened this issue Aug 3, 2023 · 0 comments
Open

[Request]: Preferences shortcut, "Shortcuts" window name/title #61

RedBearAK opened this issue Aug 3, 2023 · 0 comments
Assignees

Comments

@RedBearAK
Copy link

RedBearAK commented Aug 3, 2023

Tell us the problem or your need

This is of low importance. But should be relatively simple to deal with.

I'm requesting two things:

  1. A keybinding for the Preferences dialog. Ctrl+comma has become fairly common for this, especially in newer GTK apps.
  2. The "Shortcuts" dialog showing keyboard shortcuts has a "name" in the background that doesn't match the title displayed on the window. I would like to see this changed to "Shortcuts" just like the visible title of the window.

In X11 this is referring to the WM_NAME and _NET_WM_NAME window attributes. I think it's referred to as the window "title" more often in Wayland, but it might depend on the desktop environment.

I observed this because I am maintaining a keymapper app (https://toshy.app) that converts my keyboard behavior in Linux to working like a Mac, and I was remapping some keys to close the Atoms dialogs with my keyboard's equivalent of Cmd+W (remapped to the Escape key in this instance). The "Preferences" dialog is actually named "Preferences", and the "About" dialog is also named "About" in the window attributes. But the "Shortcuts" dialog just has the name "atoms", which is the same as the application class string of all the dialogs.

I haven't been able to pinpoint exactly where these window attributes are set for each dialog in the code, but if you point me at the right file I may be able to put together a simple PR for this.

Describe the solution you'd like

Update the window attribute "name/title" from "atoms" to "Shortcuts" to match the "Shortcuts" dialog window title displayed visibly on the title bar, like the other dialogs.

Application class attribute can stay the same (for all dialogs this is currently "atoms") or be updated to match the main window app class of "pm.mirko.Atoms". I can work with it either way.

Other solutions?

No response

Additional context and references

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants