Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong result after migration to 0.6.4 #426

Closed
Harold7665 opened this issue Dec 1, 2021 · 5 comments
Closed

Wrong result after migration to 0.6.4 #426

Harold7665 opened this issue Dec 1, 2021 · 5 comments
Assignees
Labels
🐛 bug unexpected or wrong behavior
Milestone

Comments

@Harold7665
Copy link

Harold7665 commented Dec 1, 2021

Steps to reproduce

Hello,
If you run the notebook https://github.com/activeviam/python-saccr-demo/tree/upgrade_to_0.6.2 on 0.6.2 or https://github.com/activeviam/python-saccr-demo/tree/master on 0.5.1, you get right calculation results.
You can get the data and maybe additional information here: https://drive.google.com/file/d/1IWy3wvRD2OXksqIKj6h-06mcT9iEXn3I/view?usp=sharing

Actual Result

Different calculation results on the last 0.6.4 nightly available today.

Expected Result

Same calculation results.

@Harold7665 Harold7665 added the 🐛 bug unexpected or wrong behavior label Dec 1, 2021
@tibdex
Copy link
Member

tibdex commented Dec 1, 2021

Hi Harold, can you share more information to save us time? For instance which cell to look at in which notebook to see the different results?

@Harold7665
Copy link
Author

Harold7665 commented Dec 1, 2021

Hi Thibault, sure.

You can run the whole 0.6.4 notebook then look at the first ActiveUI dashboard, page 1, and compare with the first page of the 1.Overview.pdf in the attached zip (it contains all the dashboards exported in 0.5.1, results are same in 0.6.2).
SACCR upgrade.zip

Notebooks are the same. Only the version change (and some code due to breaking changes) between 0.5.1 and 0.6.2.
In order to run it in 0.6.4, you only need to modify the file_path key to destination in the session configuration.

@Harold7665 Harold7665 removed their assignment Dec 1, 2021
@tibdex tibdex self-assigned this Dec 1, 2021
@Harold7665
Copy link
Author

Harold7665 commented Dec 1, 2021

Update: the master branch is now on version 0.6.2 (https://github.com/activeviam/python-saccr-demo)
I keep the 0.5.1 on Google Drive https://drive.google.com/file/d/1IWy3wvRD2OXksqIKj6h-06mcT9iEXn3I/view?usp=sharing if it can help working on this ticket.

@Acriss
Copy link

Acriss commented Dec 1, 2021

Hey Harold,
I'll have a look at it !
Cheers

@Acriss Acriss assigned Acriss and unassigned tibdex Dec 1, 2021
@Acriss Acriss added this to the Next release milestone Dec 7, 2021
@Acriss
Copy link

Acriss commented Dec 7, 2021

Hey Harold,
A fix has been found and merged. Next release will contain the fix !
Cheers,
Acriss

@patachoux patachoux bot closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug unexpected or wrong behavior
Projects
None yet
Development

No branches or pull requests

3 participants