[Fixes #40] Adjust stuff for CI / pre-release #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalfita
changed the title
tmplt
requested changes
Oct 16, 2022
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - [Sealed](https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed) all HAL-internal traits to disallow potentially unsound downstream trait implementations. | ||
| - Regenerated PACs with `svd2rust 0.25.1` using up-to-date (2022-05-18) SVDs. These SVDs are now vendored in this repository, instead of using a submodule. | ||
| - Cargo Workspace sorted, so local builds and crate publictions work, and CI is satisfied. |
There was a problem hiding this comment.
GitHub CI was added with in this release, so there is no need to mention that a fix was applied.
martinmortsell
approved these changes
Oct 17, 2022
This would form the next release, so we can go with next releases with a clean slate.
tmplt
requested changes
Oct 18, 2022
CHANGELOG.md
Outdated
| @@ -13,7 +13,8 @@ | |||
|
|
|||
| - [Sealed](https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed) all HAL-internal traits to disallow potentially unsound downstream trait implementations. | |||
| - Regenerated PACs with `svd2rust 0.25.1` using up-to-date (2022-05-18) SVDs. These SVDs are now vendored in this repository, instead of using a submodule. | |||
| - Cargo Workspace sorted, so local builds and crate publictions work, and CI is satisfied. | |||
| - Cargo Workspace sorted, so local builds and crate publictions work. | |||
tools/update-pacs.sh
Outdated
| pushd $pac | ||
|
|
||
| #sed -e "s|\${crate}|${crate}|g" -e "s|\${chip}|${chip}|g" -e "s|\${pac}|${pac}|g" -e "s|\${version}|${version}|g" "${top}/pac/templates/Cargo.toml.template" > Cargo.toml | ||
| #sed -e "s|\${crate}|${crate}|g" -e "s|\${chip}|${chip}|g" -e "s|\${pac}|${pac}|g" -e "s|\${version}|${version}|g" "${top}/pac/templates/README.md.template" > README.md |
tmplt
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing stuff for HAL 0.4.0 release.