Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is Broken #40

Closed
martinmortsell opened this issue Oct 13, 2022 · 6 comments
Closed

CI is Broken #40

martinmortsell opened this issue Oct 13, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@martinmortsell
Copy link
Contributor

The CI is broken since the last push.
The CI for #38 fails in a few places (where it decides to run).
First cause of failure is that the CI think every subfolder of ./pacs/ is a pac, it clears the two first characters at normally, and builds with the selected pac as a feature.
Now there is a templates folder resulting in an attempt to run cargo build --features unproven,mplates.
Second Cause of failure mostly speaks for itself:

`cargo metadata` exited with an error: error: current package believes it's in a workspace when it's not:
current:   /home/runner/work/atsamx7x-rust/atsamx7x-rust/boards/atsame70_xpro/Cargo.toml
workspace: /home/runner/work/atsamx7x-rust/atsamx7x-rust/Cargo.toml

this may be fixable by adding `boards/atsame70_xpro` to the `workspace.members` array of the manifest located at: /home/runner/work/atsamx7x-rust/atsamx7x-rust/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
cargo-fmt 

and results from the changes made to Cargo.toml in the root folder.

@martinmortsell
Copy link
Contributor Author

Related to this, when trying to figure out why #38 wasn't passing I found that a couple of the atsame70_xpro examples aren't building successfully.

@tmplt
Copy link
Member

tmplt commented Oct 13, 2022

32935d5 broke CI. There was also no PR for it, from the looks of things.

@michalfita
Copy link
Collaborator

I was making attempt to release PACs, but I couldn't. There were missing pieces of the puzzle, no Rust code changes. So I did my best to make this work bringing back some of my original ideas to the update script (originally in Python, rewritten to bash by @tmplt, but incomplete). I've managed to release PACs, but there were other issues, so I pushed what worked to develop directly so it sits there tagged.

Now, I have more changes to fix builds of other stuff and address CI, but I plan to PR these, so hopefully I'll manage to do this over weekend.

Then I'm afraid we have to scrap this repo in favour of separate repos for PACs and HAL, major reason is the size of the current one and problem with checkouts, the next reason is it would make it easier to release and tag releases per repository. I'll do this for PACs first with my new method of building them. Later I can extract full history for hal and boards directories only into the new repository. Both would free us from legacy of LFS and 40k PAC files.

@michalfita michalfita added the bug Something isn't working label Oct 13, 2022
@michalfita michalfita self-assigned this Oct 13, 2022
@michalfita michalfita added this to the HAL Release 0.4.0 milestone Oct 13, 2022
@michalfita michalfita pinned this issue Oct 13, 2022
@tmplt
Copy link
Member

tmplt commented Oct 15, 2022

I was making attempt to release PACs, but I couldn't. There were missing pieces of the puzzle [...] [rewritten to bash but incomplete]

How so? What was missing?

I'll do this for PACs first with my new method of building them.

What is this new method?

michalfita added a commit that referenced this issue Oct 16, 2022
@michalfita
Copy link
Collaborator

How so? What was missing?

PACs have to have right license = field in Cargo.toml and README.md has to be present in each. That's now fixed.

What is this new method?

The crate doesn't deliver several thousands of files, but runs svd2rust and form as libraries in build.rs - I've tested this approach with crates.io and this seem to work pretty well.

@tmplt
Copy link
Member

tmplt commented Oct 17, 2022

runs svd2rust and form as libraries in build.rs - I've tested this approach with crates.io and this seem to work pretty well.

Good work. Looking forward to see it merged.

michalfita added a commit that referenced this issue Oct 17, 2022
michalfita added a commit that referenced this issue Oct 19, 2022
[Fixes #40] Adjust stuff for CI / pre-release
[Fixes #34] Both PAC and HAL are now released
@michalfita michalfita unpinned this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants