-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart client: Ensure Monitor is always running if it is expected to be running #1036
Comments
No progress last sprint due to higher priority work |
Some progress in PR67, might complete in PR68 if the other more important stuff gets done |
Moving to current sprint as this is a significant issue, although it happens very rarely |
Implemented and manually tested during PR69 but need to add multiple additional unit tests before raising the PR |
Got back to this during PR72, added some more unit tests which exposed another problem, working on resolving that problem now. Expect to complete the PR early in PR73 |
Finished during PR74, will create PR during PR75 |
Hoping to make time to complete this in PR80 if I can find a day |
Describe the bug
An issue occurred where monitor died in an emulator instance of an app, and monitor did not restart itself.
Defensive code (most likely a cron in the NotificationService) required in order to ensure that the monitor is always kept alive unless it is in the Stopped state.
This bug needs to be fixed immediately, but see also #1032 for an enhancement to the broader issue here, of component sanity when resuming from background.
Steps to reproduce
So far, the issue is not reproducible on demand by @gkc. However gkc has seen the problem occur very occasionally when for example sshnpd is running on computer and the computer resumes from sleep. There's a race condition somewhere, which isn't surprising as the current code is a bit over-complicated and silly. (What clown wrote that code? Oh, it was me.)
Expected behavior
Monitor should always be running if it is in Started state.
The text was updated successfully, but these errors were encountered: