Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump dart-lang/setup-dart from 1.3 to 1.4 #889

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2023

Bumps dart-lang/setup-dart from 1.3 to 1.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) from 1.3 to 1.4.
- [Release notes](https://github.com/dart-lang/setup-dart/releases)
- [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md)
- [Commits](dart-lang/setup-dart@6a218f2...a57a6c0)

---
updated-dependencies:
- dependency-name: dart-lang/setup-dart
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 17, 2023
cpswan
cpswan previously approved these changes Jan 17, 2023
@cpswan
Copy link
Member

cpswan commented Jan 17, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 17, 2023

Looks like this PR is already up-to-date with trunk! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@cpswan
Copy link
Member

cpswan commented Jan 17, 2023

@gkc @murali-shris @sitaram-kalluri any ideas why this is happening?

Run flutter analyze
  flutter analyze
  shell: /usr/bin/bash -e {0}
  env:
    PUB_CACHE: /home/runner/.pub-cache
    DART_HOME: /opt/hostedtoolcache/dart-sdk
Analyzing at_client_mobile...                                   

   info • 'syncService' is deprecated and shouldn't be used. Use atClientManager.atClient.syncService • lib/src/at_client_service.dart:348:37 • deprecated_member_use

1 issue found. (ran in 7.[2](https://github.com/atsign-foundation/at_client_sdk/actions/runs/3934825279/jobs/6733881737#step:11:2)s)
Error: Process completed with exit code 1.

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

I deprecated a method.

@cpswan
Copy link
Member

cpswan commented Jan 17, 2023

@gkc so do we need to modify the tests so they don't trip up on that?

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

Yes. We need to be free to deprecate methods. I'll change the check.

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

FYI see this ticket: flutter/flutter#31918

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

Anyway ... I'll change the checks, add the --no-fatal-info flag, verify that it works and if it does then I'll make changes in the other repos also.

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

Interesting that flutter analyze exits with 1, dart analyze exits with 0

gary@gkc2019-2 at_client_mobile % flutter analyze
Analyzing at_client_mobile...                                           

   info • 'syncService' is deprecated and shouldn't be used. Use atClientManager.atClient.syncService • lib/src/at_client_service.dart:348:37 •
          deprecated_member_use

1 issue found. (ran in 0.9s)
gary@gkc2019-2 at_client_mobile % echo $?
1


gary@gkc2019-2 at_client_mobile % dart analyze
Analyzing at_client_mobile...          0.9s

   info • lib/src/at_client_service.dart:348:37 • 'syncService' is deprecated and shouldn't be used. Use atClientManager.atClient.syncService. Try
          replacing the use of the deprecated member with the replacement. • deprecated_member_use

1 issue found.
gary@gkc2019-2 at_client_mobile % echo $?
0

@gkc
Copy link
Contributor

gkc commented Jan 17, 2023

Added --no-fatal-infos flag when running flutter analyze in the github workflow

@gkc gkc self-requested a review January 17, 2023 13:07
@gkc gkc merged commit 7d07402 into trunk Jan 17, 2023
@gkc gkc deleted the dependabot/github_actions/dart-lang/setup-dart-1.4 branch January 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants