fix: unicode ve codepoints #191
Conversation
There was a problem hiding this comment.
left this script in so that you can see how I migrated the assets directory
There was a problem hiding this comment.
This was a :%s/<old emoji>/<new emoji>/g in vim
| - The reason for making this change is that shells (e.g. bash, zsh) and emoji | ||
| normalization techniques expect the variant selector to be there. Specifically | ||
| with the :hammer_and_wrench: emoji. Most shells recognize the U+1F6E0 | ||
| character as a double wide character which takes up a single column. The | ||
| U+FE0F is a zero-width character which also takes up a single column. Thus | ||
| correcting the number of columns to match the width of the characters. Without | ||
| this normalization, it becomes difficult to use the characters over the shell. |
There was a problem hiding this comment.
@cpswan here is the explainer of why I did this change. I appended U+FE0F (variant selector) to every U+1F6E0 (hammer and wrench emoji) where it was missing, thus normalizing the emojis. This variant selector is automatically added by emoji pickers on most (if not all) major platforms, hence why we have had to copy paste in the past.
|
Will make a separate issue |
|
I tried a build of this: https://hub.docker.com/layers/atsigncompany/virtualenv/normemojitest/images/sha256-17fe36814f9a26d81539ffbc9e7b42b0272865669dcfeed27fe0dedc665b5f94?context=explore Wasn't able to get it running nicely... the emojis in the supervisor dashboard are still in the old format. It would be nice if this just worked, but I will not spend anymore time on it. |
- What I did
- How I did it
- How to verify it
@cpswan can I get some help with a test build for this?
- Description for the changelog
fix: unicode ve codepoints