Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add close and cramAuthenticate as public methods to AtLookUp interface #421

Closed
murali-shris opened this issue Oct 6, 2023 · 0 comments · Fixed by #433
Closed

add close and cramAuthenticate as public methods to AtLookUp interface #421

murali-shris opened this issue Oct 6, 2023 · 0 comments · Fixed by #433
Assignees
@srieteja
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

  • currently close and authenticate_cram are exposed as public methods in AtLookupImpl and are not part of AtLookUp interface

Describe the solution you'd like

  • add close and cramAuthenticate (similar to pkamAuthenticate) to AtLookUp interface
  • deprecate authenticate_cram method in AtLookUpImpl and copy the implementation to the new method cramAuthenticate

Describe alternatives you've considered

No response

Additional context

No response
@murali-shris murali-shris added the enhancement New feature or request label Oct 6, 2023
@murali-shris murali-shris changed the title expose close and cramAuth as public methods in AtLookUp interface add close and cramAuthenticate as public methods to AtLookUp interface Oct 6, 2023
@srieteja srieteja mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srieteja srieteja

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce cramAuthenticate and close into atLookup interface atsign-foundation/at_libraries
2 participants
@murali-shris @srieteja