Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SortedBag.isSubset(of:) et al. don't do multiset comparisons yet #22

Closed
lorentey opened this issue Nov 7, 2016 · 0 comments
Closed

SortedBag.isSubset(of:) et al. don't do multiset comparisons yet #22

lorentey opened this issue Nov 7, 2016 · 0 comments

Comments

@lorentey
Copy link
Collaborator

lorentey commented Nov 7, 2016

SortedBag's subset comparison does not count multiplicities, so it returns incorrect results for a multiset. E.g., SortedBag([1, 1]).isSubset(of: [1]) should be false, but it currently returns true.

This breaks the new tests added in a7f642e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorentey