Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Create a Dockerfile #3789

Closed
stevepeak opened this issue Jan 9, 2018 · 10 comments
Closed

Create a Dockerfile #3789

stevepeak opened this issue Jan 9, 2018 · 10 comments

Comments

@stevepeak
Copy link

Add a Dockerfile and officially support a Docker build to help adaption rate and customer onboarding.

@dustywilson I found your Docker build and would love to know if you had any issues or feedback that could help Noms create an official Dockerized version of the product. Thanks!

@stevepeak
Copy link
Author

I've created the organization on Docker Hub https://hub.docker.com/u/noms/ -- will transfer over ownership to the main contributors once I get their emails to invite. 👍

@aboodman
Copy link
Contributor

aboodman commented Jan 9, 2018

Maybe add the missing deps you found @stevepeak?

@stevepeak
Copy link
Author

Certainly! I'll be submitting a PR soon with a working container and instructions on how to maintain (which I'm happy to do).

@emmaly
Copy link

emmaly commented Jan 10, 2018

@stevepeak We haven't been using it lately, but when we were using it we had zero problems whatsoever. You're welcome to use the Dockerfile I created verbatim or modified however you want. Mine was super simple and worked fine, but I don't know if there have been any important changes in recent times that would cause you to want to make a change as to how it is done. I know that new features have come out for Docker to support multi-stage builds, so you could, in theory, build it in such a way that you use golang base image to do the build, but then distribute a container that contains literally one single binary (assuming there's no shelling out for anything, need non-embedded CA certs, etc). If I were to re-implement now, that's what I would do.

https://docs.docker.com/engine/userguide/eng-image/multistage-build/ has info on how to go about doing that, and I highly recommend understanding that before proceeding with a new Dockerfile.

@kav
Copy link

kav commented Aug 6, 2018

Looks like the Dockerfile in the repo is pretty good. Any chance someone can publish it to the noms organization in dockerhub so the rest of us can just pull it from there?

@kav
Copy link

kav commented Aug 7, 2018

Might also want to add:

ENV CGO_ENABLED=0
ENV GOOS=linux

to the build container so the runtime container works. Happy to PR if you are still taking PRs

@emmaly
Copy link

emmaly commented Aug 7, 2018

FYI we're going to delete our repo at scjalliance/noms. Your Dockerfile in this repo is looking very good, so I see no point in keeping the one at scjalliance around. (FYI I was formerly @dustywilson, but changed username.) Thanks for taking this task forward!

@aboodman
Copy link
Contributor

aboodman commented Aug 7, 2018

Might also want to add:

Done.

@aboodman
Copy link
Contributor

aboodman commented Aug 7, 2018

Any chance someone can publish it to the noms organization in dockerhub so the rest of us can just pull it from there?

Done: https://hub.docker.com/r/noms/noms/.

@aboodman aboodman closed this as completed Aug 7, 2018
@aboodman
Copy link
Contributor

aboodman commented Aug 7, 2018

I also set it up to autobuild, so it should stay up to date.

reltuk pushed a commit to dolthub/dolt that referenced this issue Jul 24, 2019
* Add a few environment variables per suggestion: (#3809)

attic-labs/noms#3789 (comment)

* Add more configuration specifically aws region
* move default region to single place
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants