Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What happens if a PR gets merged while a package author is replacing a tag? #6

Closed
tkelman opened this issue Dec 19, 2016 · 1 comment
Closed

What happens if a PR gets merged while a package author is replacing a tag? #6

tkelman opened this issue Dec 19, 2016 · 1 comment

Comments

@tkelman
Copy link
Contributor

tkelman commented Dec 19, 2016

IIUC, the recommended update method here to make changes to an open metadata PR is to leave the PR open, delete the release then replace it, right? Or if you make a new release while an existing PR is still open, does it get added to the same PR or make a new one?
@tkelman
Copy link
Contributor Author

tkelman commented Dec 19, 2016

looks like deleting a release doesn't release the tag, so that would still have to be done manually if someone wants to replace it before it gets published. but if the PR stays open, then there's a window where the PR might get merged for a tag that is in the process of being replaced

@tkelman tkelman mentioned this issue Jan 29, 2017
Closed
@tkelman tkelman closed this as completed Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkelman