Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to the installation wizard #68

Closed
wants to merge 15 commits into from
Closed

Various fixes to the installation wizard #68

wants to merge 15 commits into from

Commits on May 1, 2013

  1. Don't bother with vim .swp files

    @acli
    acli committed May 1, 2013
    Configuration menu
    Copy the full SHA
    c2b7643 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2013

  1. Do not display irrelevant, spurious errors if we cannot even get a co… 

    …nnection to the SQL server
    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    ae074dc View commit details
    Browse the repository at this point in the history

  2. The password contains extra backslashes which needs to be removed. Fixes 

     #3 (in Ambrose's fork).
    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    dadca2e View commit details
    Browse the repository at this point in the history

  3. Do not check in include/config.inc.php

    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    5715e82 View commit details
    Browse the repository at this point in the history

  4. Wrong documentation format - should be @return not @param

    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    4f55f10 View commit details
    Browse the repository at this point in the history

  5. Password needs to be re-escaped before saving. Fixes #10 in Ambrose's… 

    … fork.
    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    3319688 View commit details
    Browse the repository at this point in the history

  6. Should not create .gitignore upstream. Sorry.

    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    4b33e20 View commit details
    Browse the repository at this point in the history

  7. Edits per discussion. Not yet tested.

    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    822b89a View commit details
    Browse the repository at this point in the history

  8. Reverted the $addslashes / $stripslashes changes until I can figure o… 

    …ut why PHP is erroring out on $addslashes
    @acli
    acli committed May 2, 2013
    Configuration menu
    Copy the full SHA
    0f63335 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2013

  1. Added back the $addslashes / $stripslashes changes. They *are* define… 

    …d somewhere; they just needed to be declared global.
    @acli
    acli committed May 3, 2013
    Configuration menu
    Copy the full SHA
    33705d0 View commit details
    Browse the repository at this point in the history

  2. config_template.php should use addslashes, not $addslashes because we… 

    … are specifically trying to write a PHP literal string; we are not dealing with CGI queries here
    @acli
    acli committed May 3, 2013
    Configuration menu
    Copy the full SHA
    1a44c4b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2013

  1. Missing urldecode, so random characters in the password got totally m… 

    …angled, causing the Access denied error that eventually caused no version string to be returned. Fixes #21 in my fork.
    @acli
    acli committed May 4, 2013
    Configuration menu
    Copy the full SHA
    56cbad6 View commit details
    Browse the repository at this point in the history

  2. Missing urldecode, so random characters in the password got totally m… 

    …angled, causing the Access denied error that eventually caused no version string to be returned. Fixes #21 in my fork.
    @acli
    acli committed May 4, 2013
    Configuration menu
    Copy the full SHA
    4806431 View commit details
    Browse the repository at this point in the history

  3. Merge branch '20130504_INSTALLER_STEP6_MYSQL_VERSION'

    @acli
    acli committed May 4, 2013
    Configuration menu
    Copy the full SHA
    e79c65a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2013

  1. Update the function comments based on the findings

    @acli
    acli committed May 7, 2013
    Configuration menu
    Copy the full SHA
    6b6c487 View commit details
    Browse the repository at this point in the history